Deploy metadata in end to end tests #2186

Kerkesni · 2025-01-21T17:47:32Z

Deploy metadata from chart
Wait for metadata components to start in order : repd -> bucketd -> cloudserver
Manually add the proper endpoint in Cloudserver config
Only deploy metadata in end2end-sharded

bert-e · 2025-01-21T17:47:36Z

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-01-21T17:47:43Z

Incorrect fix version

The Fix Version/s in issue ZENKO-4414 contains:

2.11.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.10.12

Please check the Fix Version/s of ZENKO-4414, or the target
branch of this pull request.

bert-e · 2025-01-22T11:41:18Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Issue: ZENKO-4414

Metadata components need to be started in the order repd -> bucketd -> cloudserver as they are not able to recover on their own when a component they depend on is not available at startup. Issue: ZENKO-4414

Configuration of the test environement is done through an image built in the build-test-image job, this image contains the list of location details used to initialize the locations. This list isn't updated when only retrying the end to end test jobs, and the bucket is create using the env var passed to the pod. So we endup creating the bucket with the updated retry count but configure the location with the old bucket name which fails as pensieve won't be able to find that bucket. Issue: ZENKO-4414

Issue: ZENKO-4414

francoisferrand · 2025-01-30T18:06:37Z

.github/actions/deploy/action.yaml

@@ -83,6 +83,11 @@ runs:
      shell: bash
      run: sh tests/smoke/deploy-sorbet-resources.sh end2end
      working-directory: ./.github/scripts/end2end/operator
+    - name: Deploy metadata
+      shell: bash
+      run: bash deploy-metadata.sh


We are already running with bash, so make it executable and execute just:

Suggested change

run: bash deploy-metadata.sh

run: ./deploy-metadata.sh

bert-e · 2025-01-30T18:06:47Z

Incorrect fix version

The Fix Version/s in issue ZENKO-4414 contains:

2.10.12

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.10.13

Please check the Fix Version/s of ZENKO-4414, or the target
branch of this pull request.

francoisferrand · 2025-01-30T18:07:39Z

.github/actions/deploy/action.yaml

+      shell: bash
+      run: bash deploy-metadata.sh
+      working-directory: ./.github/scripts/end2end
+      if: ${{ env.ENABLE_RING_TESTS == 'true' }}


better to have it as an input rather than an env variable
(the input parameter may however takes its "default" value from env)

francoisferrand · 2025-01-30T18:14:39Z

.github/scripts/end2end/deploy-metadata.sh

+# wait for all bucketd pods to start serving port 9000
+wait_for_all_pods_behind_services metadata-bucketd metadata 9000 60
+
+# manually add "s3c.local" to the rest endpoints list as it's not configurable in the chart


why do we need s3c.local ?

i did not need such patch on my artesca cluster (in namespace default i think), just installed the chart and created the artesca location pointed at s3c-cloudserver.default.svc.cluster.local

francoisferrand · 2025-01-30T18:16:05Z

.github/workflows/end2end.yaml

-      # - scality-cloud
+    env:
+      ENABLE_RING_TESTS: "true"
+      GIT_ACCESS_TOKEN: ${{ secrets.GIT_ACCESS_TOKEN }}


credentials should not be added to env, esp. at such broad "scale" : best to pass them via inputs, in the place where they are needed

Kerkesni force-pushed the improvement/ZENKO-4414 branch 3 times, most recently from e03ffd7 to 15d54c7 Compare January 22, 2025 11:41

Kerkesni force-pushed the improvement/ZENKO-4414 branch 9 times, most recently from 2468755 to ac95b9c Compare January 23, 2025 17:28

Kerkesni marked this pull request as ready for review January 24, 2025 15:15

Kerkesni force-pushed the improvement/ZENKO-4414 branch 3 times, most recently from 0efddbf to 9055c5f Compare January 24, 2025 16:06

francoisferrand changed the base branch from improvement/ZENKO-4966-1.29 to development/2.10 January 28, 2025 11:32

Kerkesni force-pushed the improvement/ZENKO-4414 branch 2 times, most recently from 8f823ba to 8e060ea Compare January 28, 2025 11:47

Kerkesni added 4 commits January 28, 2025 12:54

deploy metadata in end2end sharded tests

c01dc96

Issue: ZENKO-4414

ensure all metadata components are started properly

4acbbb9

Metadata components need to be started in the order repd -> bucketd -> cloudserver as they are not able to recover on their own when a component they depend on is not available at startup. Issue: ZENKO-4414

only deploy metadata when needed

5a84228

Issue: ZENKO-4414

Kerkesni force-pushed the improvement/ZENKO-4414 branch from 8e060ea to 5a84228 Compare January 28, 2025 11:55

francoisferrand reviewed Jan 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy metadata in end to end tests #2186

Deploy metadata in end to end tests #2186

Kerkesni commented Jan 21, 2025 •

edited

Loading

bert-e commented Jan 21, 2025

bert-e commented Jan 21, 2025

bert-e commented Jan 22, 2025

francoisferrand Jan 30, 2025

bert-e commented Jan 30, 2025

francoisferrand Jan 30, 2025

francoisferrand Jan 30, 2025

francoisferrand Jan 30, 2025

Deploy metadata in end to end tests #2186

Are you sure you want to change the base?

Deploy metadata in end to end tests #2186

Conversation

Kerkesni commented Jan 21, 2025 • edited Loading

bert-e commented Jan 21, 2025

Hello kerkesni,

bert-e commented Jan 21, 2025

Incorrect fix version

bert-e commented Jan 22, 2025

Waiting for approval

francoisferrand Jan 30, 2025

Choose a reason for hiding this comment

bert-e commented Jan 30, 2025

Incorrect fix version

francoisferrand Jan 30, 2025

Choose a reason for hiding this comment

francoisferrand Jan 30, 2025

Choose a reason for hiding this comment

francoisferrand Jan 30, 2025

Choose a reason for hiding this comment

Kerkesni commented Jan 21, 2025 •

edited

Loading